Bug 35357

Summary: Two editing tests fail after DumpRenderTree run loop changes
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
proposed fix
none
proposed fix
none
your wish is my command mitz: review+

Alexey Proskuryakov
Reported 2010-02-24 13:18:36 PST
I'm not sure why exactly this happens, and it's possible that the tests aren't quite right - but there is a less invasive fix for the Java plug-in that we can use for now.
Attachments
proposed fix (3.14 KB, patch)
2010-02-24 13:23 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed fix (5.61 KB, patch)
2010-02-24 13:42 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
your wish is my command (3.46 KB, patch)
2010-02-24 13:54 PST, Alexey Proskuryakov 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-02-24 13:23:15 PST
Created attachment 49427 [details] proposed fix
mitz
Comment 2 2010-02-24 13:37:13 PST
Comment on attachment 49427 [details] proposed fix Can’t DumpRenderTree be modified to use an NSApplication subclass? I don’t think it’s necessary to resort to runtime trickery.
Alexey Proskuryakov
Comment 3 2010-02-24 13:42:09 PST
Created attachment 49432 [details] proposed fix
Alexey Proskuryakov
Comment 4 2010-02-24 13:54:59 PST
Created attachment 49433 [details] your wish is my command
Alexey Proskuryakov
Comment 5 2010-02-24 13:58:54 PST
Committed revision 55200.
Simon Fraser (smfr)
Comment 6 2013-07-30 21:18:12 PDT
This change made DRT run a busyloop while waiting for tests to complete, rather than idling the event loop.
Simon Fraser (smfr)
Comment 7 2013-07-30 21:34:23 PDT
Fixing via bug 119317.
Note You need to log in before you can comment on or make changes to this bug.