Summary: | [Qt] GraphicsLayer: support perspective and 3D transforms | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, ismail | ||||||
Priority: | P2 | Keywords: | Qt | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Noam Rosenthal
2010-02-15 14:02:20 PST
Created attachment 48779 [details]
support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective
Thanks Kim Gronholm from Starlight/Novomok for doing most of the work on this patch
Comment on attachment 48779 [details]
support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective
Nice work :) LGTM.
Comment on attachment 48779 [details]
support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective
let's roll...
Comment on attachment 48779 [details] support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective Rejecting patch 48779 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: pository/webkit/trunk ... M ChangeLog M WebCore/ChangeLog M WebCore/platform/graphics/qt/GraphicsLayerQt.cpp M WebKit.pri A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://webkit-commit-queue.appspot.com/results/276227 Created attachment 48907 [details]
Oops, had an "OOPS" in my ChangeLog :)
This has already been reviewed, just need to rubber-stamp it :)
Comment on attachment 48907 [details]
Oops, had an "OOPS" in my ChangeLog :)
r+, cq+ again to land the patch.
Comment on attachment 48907 [details] Oops, had an "OOPS" in my ChangeLog :) Clearing flags on attachment: 48907 Committed r54906: <http://trac.webkit.org/changeset/54906> All reviewed patches have been landed. Closing bug. Addding these defines to WebKit.pri is not right, --minimal should disable such defines. These should be handled via build-webkit script somehow. Hmm, you got a point. I'm not a build-system expert but I've created bug 35100 and will look into that. |