Bug 34793

Summary: [Qt] QScriptValue::toBool problem
Product: WebKit Reporter: Jędrzej Nowacki <jedrzej.nowacki>
Component: JavaScriptCoreAssignee: Jędrzej Nowacki <jedrzej.nowacki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 31863    
Attachments:
Description Flags
Fix v1 none

Description Jędrzej Nowacki 2010-02-10 04:02:08 PST 
QScriptValue::toBool (and toBoolean) returns a bad value for a numbers like 0, NaN and for an empty strings.
Comment 1 Jędrzej Nowacki 2010-02-10 04:08:54 PST 
Created attachment 48485 [details]
Fix v1
Comment 2 Simon Hausmann 2010-02-10 04:26:49 PST 
Comment on attachment 48485 [details]
Fix v1

LGTM
Comment 3 WebKit Commit Bot 2010-02-10 09:55:18 PST 
Comment on attachment 48485 [details]
Fix v1

Clearing flags on attachment: 48485

Committed r54605: <http://trac.webkit.org/changeset/54605>
Comment 4 WebKit Commit Bot 2010-02-10 09:55:23 PST 
All reviewed patches have been landed.  Closing bug.