Bug 34775 – Black Highlight when selecting certain elements

• Component: WebKit Qt
• Status: RESOLVED DUPLICATE

[Aaron Conran]

Created attachment 48439 [details]
Screenshot.

Certain elements will highlight with a black background instead of the default.

This can completely mask elements and make them unusable until unselected.

For a simple reproducible example, compile the "Fancy Browser Example" shipped with Qt.

Navigate to:
http://www.extjs.com/deploy/dev/examples/grid/array-grid.html

Do a drag selection from the text above and go down. 

Certain elements will highlight with black instead of the default.

[Aaron Conran]

It's also worth noting that this example works fine in Chrome and Safari.

[Nick Young]

Created attachment 48617 [details]
Naive Patch

This naive patch solves the problem for me.
However, It seems to be indicative of a deeper problem where we have a brush with an invalid color that does not have a style == Qt::NoBrush.

[Kenneth Rohde Christiansen]

Ah I remember that we had such a similar issue before. Do you remember the details Simon?

[Ariya Hidayat]

I guess this is because of my commit: http://trac.webkit.org/changeset/37421

The optimization does not take into account that the color could be bogus.

The patch from Nick looks good to solve this problem.

[Ariya Hidayat]

> I guess this is because of my commit: http://trac.webkit.org/changeset/37421

False alarm. Excluding the optimization still shows the same behaviour.

Nick: if you include some ChangeLog, then we can land your patch.

[Tor Arne Vestbø]

Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs

Specifically:

  - The 'QtWebKit' component should only be used for bugs/features in the
    public QtWebKit API layer, not to signify that the bug is specific to
    the Qt port of WebKit

      http://trac.webkit.org/wiki/QtWebKitBugs#Component

  - Add the keyword 'Qt' to signal that it's a Qt-related bug

      http://trac.webkit.org/wiki/QtWebKitBugs#Keywords

[Ariya Hidayat]

Fixed by the commit http://trac.webkit.org/changeset/58949

[Simon Hausmann]

*** This bug has been marked as a duplicate of bug 38523 ***