| Summary: | [Qt] QScriptValue::toNumber() is broken | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jędrzej Nowacki <jedrzej.nowacki> | ||||||||
| Component: | JavaScriptCore | Assignee: | Jędrzej Nowacki <jedrzej.nowacki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, webkit.review.bot | ||||||||
| Priority: | P2 | Keywords: | Qt | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 31863 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 48147 [details]
fix v1
Attachment 48147 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Ignoring "JavaScriptCore/qt/api/qscriptvalue_p.h": this file is exempt from the style guide.
JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue.h:76: toNumber_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue.h:124: toNumber_initData is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue.h:125: toNumber_makeData is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue.h:126: toNumber_test is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 4
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 48397 [details]
Fix v2
Comment on attachment 48397 [details] Fix v2 Clearing flags on attachment: 48397 Committed r54579: <http://trac.webkit.org/changeset/54579> All reviewed patches have been landed. Closing bug. |
Created attachment 48144 [details] use cases There are different use cases for which the toNumber() returns incorrect value. The use cases in the attachment.