Summary: | Crash in Safari opening new tabs/windows to "same page" | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
Component: | Page Loading | Assignee: | Brady Eidson <beidson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, gustavo, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Brady Eidson
2010-02-01 12:27:26 PST
In Radar as <rdar://problem/7593857> Created attachment 47863 [details]
Patch v1
Attachment 47863 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/loader/FrameLoader.cpp:3822: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Total errors found: 1
If any of these errors are false positives, please file a bug against check-webkit-style.
*** Bug 34443 has been marked as a duplicate of this bug. *** Comment on attachment 47863 [details]
Patch v1
sorry, forgot to fill out changelogs (and will fix the style-check issue)
Created attachment 47865 [details]
v2 - Fill out changelogs and fix style failure
Attachment 47865 [details] was posted by a committer and has review+, assigning to Brady Eidson for commit.
Yup, landed earlier in http://trac.webkit.org/changeset/54145 |