Summary: | [BREWMP] Port FileSystem | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kwang Yul Seo <skyul> | ||||||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | beergun, commit-queue, joybro201, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Other | ||||||||||||||
OS: | Other | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 33564 | ||||||||||||||
Attachments: |
|
Description
Kwang Yul Seo
2010-01-29 03:19:35 PST
Created attachment 47696 [details]
Port FileSystem
Attachment 47696 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/brew/FileSystemBrew.cpp:38: Alphabetical sorting problem. [build/include_order] [4]
WebCore/platform/brew/FileSystemBrew.cpp:41: Alphabetical sorting problem. [build/include_order] [4]
WebCore/platform/brew/FileSystemBrew.cpp:43: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 3
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 47697 [details]
Port FileSystem
Sort header files alphabetically.
Comment on attachment 47697 [details]
Port FileSystem
Given how often you use this in various places, seems you might want to add it to a common header at some point:
49 IShell* shell = reinterpret_cast<AEEApplet*>(GETAPPINSTANCE())->m_pIShell;
This seems like a bad idea:
47 static PassOwnPtr<IFileMgr> createIFileMgr()
can you actually call "delete" with an IFileMgr pointer ant it will do the right thing? It doesn't need some special release call?
I modified OwnPtr to delete an IFileMgr pointer correctly though the patch is not submitted yet. However, GOwnPtr-like smart pointer sounds better as you suggested in https://bugs.webkit.org/show_bug.cgi?id=34412. Created attachment 48012 [details] Port FileSystem Use OwnPtrBrew submitted in https://bugs.webkit.org/show_bug.cgi?id=34518 Comment on attachment 48012 [details] Port FileSystem createFileMgr can be replaced with createInstanceBrew submitted in https://bugs.webkit.org/show_bug.cgi?id=34705. Wait until it is reviewed. Created attachment 58214 [details]
Revised patch
Created attachment 58747 [details]
Revised patch
Fix a typo: utf -> utf8
Comment on attachment 58747 [details]
Revised patch
Looks ok
Comment on attachment 58747 [details] Revised patch Clearing flags on attachment: 58747 Committed r61729: <http://trac.webkit.org/changeset/61729> All reviewed patches have been landed. Closing bug. |