Bug 34518 - [BREWMP] Implement OwnPtrBrew to make sure BREW instances are freed.
Summary: [BREWMP] Implement OwnPtrBrew to make sure BREW instances are freed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency treegraph
 
Reported: 2010-02-03 03:01 PST by Kwang Yul Seo
Modified: 2010-02-03 13:17 PST (History)
3 users (show)

See Also:


Attachments
Patch (6.55 KB, patch)
2010-02-03 03:03 PST, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-02-03 03:01:19 PST
Add OwnPtrBrew to free BREW instances.
Comment 1 Kwang Yul Seo 2010-02-03 03:03:38 PST
Created attachment 48006 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-02-03 12:59:51 PST
Comment on attachment 48006 [details]
Patch

Seems we should eventually share more code between things like this and GOwnPtr or RetainPtr.  No need for each platform to copy/paste.

If you'd like to file a bug about such code sharing, that'd be great.

This looks fine to me.
Comment 3 WebKit Commit Bot 2010-02-03 13:17:28 PST
Comment on attachment 48006 [details]
Patch

Clearing flags on attachment: 48006

Committed r54294: <http://trac.webkit.org/changeset/54294>
Comment 4 WebKit Commit Bot 2010-02-03 13:17:36 PST
All reviewed patches have been landed.  Closing bug.