Bug 34166

Summary: [Android] Android lacks V8 equivalent of JNIBridgeJSC
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebKit Misc.Assignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, commit-queue, eric, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Bug Depends on:    
Bug Blocks: 32154    
Attachments:
Description Flags
Patch
none
Patch ariya.hidayat: review+, steveblock: commit-queue-

Steve Block
Reported 2010-01-26 06:58:18 PST
The JSC-specific classes JavaField and JavaArray were moved from JNIBridge to JNIBridgeJSC in http://trac.webkit.org/changeset/53849 See https://bugs.webkit.org/show_bug.cgi?id=33958 Android requires a V8 version of JNIBridgeJSC for the V8 version of JavaField
Attachments
Patch (5.78 KB, patch)
2010-01-29 03:54 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch (6.20 KB, patch)
2010-01-29 04:01 PST, Steve Block 		ariya.hidayat: review+
steveblock: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-01-29 03:54:42 PST
Created attachment 47700 [details] Patch
Steve Block
Comment 2 2010-01-29 04:01:56 PST
Created attachment 47702 [details] Patch
Ariya Hidayat
Comment 3 2010-02-01 07:50:30 PST
Comment on attachment 47702 [details] Patch LGTM.
Eric Seidel (no email)
Comment 4 2010-02-01 16:13:14 PST
Attachment 47702 [details] was posted by a committer and has review+, assigning to Steve Block for commit.
Steve Block
Comment 5 2010-02-01 16:25:21 PST
Comment on attachment 47702 [details] Patch Will land manually
Steve Block
Comment 6 2010-02-01 16:36:01 PST
Landed manually as http://trac.webkit.org/changeset/54175 Closing bug as resolved fixed.
Note You need to log in before you can comment on or make changes to this bug.