Bug 34166 - [Android] Android lacks V8 equivalent of JNIBridgeJSC
Summary: [Android] Android lacks V8 equivalent of JNIBridgeJSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks: 32154
  Show dependency tree / graph
 
Reported: 2010-01-26 06:58 PST by Steve Block
Modified: 2010-02-01 16:36 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.78 KB, patch)
2010-01-29 03:54 PST, Steve Block 		no flags Details | Formatted Diff | Diff
Patch (6.20 KB, patch)
2010-01-29 04:01 PST, Steve Block 		ariya.hidayat: review+
steveblock: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-01-26 06:58:18 PST 
The JSC-specific classes JavaField and JavaArray were moved from JNIBridge to JNIBridgeJSC in http://trac.webkit.org/changeset/53849 See  https://bugs.webkit.org/show_bug.cgi?id=33958

Android requires a V8 version of JNIBridgeJSC for the V8 version of JavaField
Comment 1 Steve Block 2010-01-29 03:54:42 PST 
Created attachment 47700 [details]
Patch
Comment 2 Steve Block 2010-01-29 04:01:56 PST 
Created attachment 47702 [details]
Patch
Comment 3 Ariya Hidayat 2010-02-01 07:50:30 PST 
Comment on attachment 47702 [details]
Patch

LGTM.
Comment 4 Eric Seidel (no email) 2010-02-01 16:13:14 PST 
Attachment 47702 [details] was posted by a committer and has review+, assigning to Steve Block for commit.
Comment 5 Steve Block 2010-02-01 16:25:21 PST 
Comment on attachment 47702 [details]
Patch

Will land manually
Comment 6 Steve Block 2010-02-01 16:36:01 PST 
Landed manually as http://trac.webkit.org/changeset/54175

Closing bug as resolved fixed.