Bug 33795

Summary: [v8] [Android] V8 bindings for touch events are missing.
Product: WebKit Reporter: Ben Murdoch <benm>
Component: WebCore Misc.Assignee: Ben Murdoch <benm>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, hausmann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Bug Depends on:    
Bug Blocks: 32485    
Attachments:
Description Flags
Patch. japhet: review+, benm: commit-queue-

Description Ben Murdoch 2010-01-18 05:51:12 PST
There are currently no V8 bindings upstream for touch events.

Patch to follow shortly.
Comment 1 Ben Murdoch 2010-02-17 05:07:13 PST
Created attachment 48895 [details]
Patch.
Comment 2 Nate Chapin 2010-02-17 10:46:23 PST
Comment on attachment 48895 [details]
Patch.

Looks good.

Ignorant question: Does this patch require changes to the Android build files?
Comment 3 Ben Murdoch 2010-02-17 10:57:31 PST
(In reply to comment #2)
> (From update of attachment 48895 [details])
> Looks good.
> 
> Ignorant question: Does this patch require changes to the Android build files?

Ah, I thought these were already in the upstream version of our makefile. Turns out they are not. I can amend the Android makefiles and land this patch without another review, or would you like me to send another patch?

Thanks, Ben
Comment 4 Ben Murdoch 2010-02-18 02:22:01 PST
Comment on attachment 48895 [details]
Patch.

Landed as r54950, closing bug.