Summary: | check-webkit-style: Finish eliminating need for global _CppStyleState instance. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Jerdonek <cjerdonek> | ||||||||
Component: | Tools / Tests | Assignee: | Chris Jerdonek <cjerdonek> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, cjerdonek, commit-queue, eric, hamaji, levin | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 33678 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Chris Jerdonek
2010-01-16 12:23:35 PST
Created attachment 46746 [details] Proposed patch The diff for this patch assumes the patch for bug 33678 has been committed. Created attachment 46748 [details]
Proposed patch 2
Missed a change in checker.process_patch() and added a FIXME.
Created attachment 46767 [details] Proposed patch 2 (resubmit) Resubmitting the latest patch to trigger the style-check, etc. now that the patch in bug 33678 has been committed. Comment on attachment 46767 [details]
Proposed patch 2 (resubmit)
Looks good.
Comment on attachment 46767 [details] Proposed patch 2 (resubmit) Clearing flags on attachment: 46767 Committed r53382: <http://trac.webkit.org/changeset/53382> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > (From update of attachment 46767 [details]) > Looks good. Thanks a lot, Shinichiro. |