Bug 33764

Summary: check-webkit-style: Finish eliminating need for global _CppStyleState instance.
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: Tools / TestsAssignee: Chris Jerdonek <cjerdonek>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, commit-queue, eric, hamaji, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 33678    
Bug Blocks:    
Attachments:
Description Flags
Proposed patch
cjerdonek: commit-queue-
Proposed patch 2
cjerdonek: commit-queue-
Proposed patch 2 (resubmit) none

Chris Jerdonek
Reported 2010-01-16 12:23:35 PST
Only verbose_level is left now.
Attachments
Proposed patch (25.33 KB, patch)
2010-01-16 13:04 PST, Chris Jerdonek 		cjerdonek: commit-queue-
DetailsFormatted DiffDiff
Proposed patch 2 (25.90 KB, patch)
2010-01-16 13:17 PST, Chris Jerdonek 		cjerdonek: commit-queue-
DetailsFormatted DiffDiff
Proposed patch 2 (resubmit) (25.90 KB, patch)
2010-01-17 16:12 PST, Chris Jerdonek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-01-16 13:04:24 PST
Created attachment 46746 [details] Proposed patch The diff for this patch assumes the patch for bug 33678 has been committed.
Chris Jerdonek
Comment 2 2010-01-16 13:17:21 PST
Created attachment 46748 [details] Proposed patch 2 Missed a change in checker.process_patch() and added a FIXME.
Chris Jerdonek
Comment 3 2010-01-17 16:12:24 PST
Created attachment 46767 [details] Proposed patch 2 (resubmit) Resubmitting the latest patch to trigger the style-check, etc. now that the patch in bug 33678 has been committed.
Shinichiro Hamaji
Comment 4 2010-01-17 17:33:18 PST
Comment on attachment 46767 [details] Proposed patch 2 (resubmit) Looks good.
WebKit Commit Bot
Comment 5 2010-01-17 18:22:50 PST
Comment on attachment 46767 [details] Proposed patch 2 (resubmit) Clearing flags on attachment: 46767 Committed r53382: <http://trac.webkit.org/changeset/53382>
WebKit Commit Bot
Comment 6 2010-01-17 18:22:56 PST
All reviewed patches have been landed. Closing bug.
Chris Jerdonek
Comment 7 2010-01-17 19:17:34 PST
(In reply to comment #4) > (From update of attachment 46767 [details]) > Looks good. Thanks a lot, Shinichiro.
Note You need to log in before you can comment on or make changes to this bug.