Bug 33719

Summary: [Android] Android platform specific PlatformTouchEvent and PlatformTouchPoint implementations are not upstream.
Product: WebKit Reporter: Ben Murdoch <benm>
Component: WebCore Misc.Assignee: Ben Murdoch <benm>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, android-webkit-unforking, commit-queue, eric, hausmann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Bug Depends on:    
Bug Blocks: 32485    
Attachments:
Description Flags
Android specific files. none

Ben Murdoch
Reported 2010-01-15 09:09:07 PST
The Android implementations of WebCore/platform/PlatformTouchEvent and WebCore/platform/PlatformTouchPoint need to be upstreamed. Patch to follow shortly.
Attachments
Android specific files. (7.08 KB, patch)
2010-01-21 08:19 PST, Ben Murdoch 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Murdoch
Comment 1 2010-01-21 08:19:00 PST
Created attachment 47119 [details] Android specific files.
Eric Seidel (no email)
Comment 2 2010-01-21 16:54:23 PST
Comment on attachment 47119 [details] Android specific files. Does this cause Andriod to pass some new tests now?
Ben Murdoch
Comment 3 2010-01-22 02:38:14 PST
(In reply to comment #2) > (From update of attachment 47119 [details]) > Does this cause Andriod to pass some new tests now? Well, yes and no :) There aren't many touch events test upstream yet as this feature was only landed in the last month or so, and most of those tests are synchronous whereas on Android touch events are asynchronous. So if I can refactor those tests to work in an asynchronous manner (which I've started to do locally, need to send a patch), then yes we should pass them.
WebKit Commit Bot
Comment 4 2010-01-22 03:42:13 PST
Comment on attachment 47119 [details] Android specific files. Rejecting patch 47119 from commit-queue. Failed to run "['WebKitTools/Scripts/run-javascriptcore-tests']" exit_code: 139 Last 500 characters of output: DING NATIVE TARGET JavaScriptCore OF PROJECT JavaScriptCore WITH CONFIGURATION Release === Checking Dependencies... PhaseScriptExecution /Users/eseidel/Projects/CommitQueue/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Script-9319586B09D9F91A00A56FD4.sh cd /Users/eseidel/Projects/CommitQueue/JavaScriptCore /bin/sh -c /Users/eseidel/Projects/CommitQueue/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Script-9319586B09D9F91A00A56FD4.sh Compiling jsc failed! Full output: http://webkit-commit-queue.appspot.com/results/203746
Ben Murdoch
Comment 5 2010-01-22 04:08:10 PST
Comment on attachment 47119 [details] Android specific files. Try the commit queue again, as I can't see why my patch would cause JSC to fail to compile...
WebKit Commit Bot
Comment 6 2010-01-22 04:30:29 PST
Comment on attachment 47119 [details] Android specific files. Clearing flags on attachment: 47119 Committed r53695: <http://trac.webkit.org/changeset/53695>
WebKit Commit Bot
Comment 7 2010-01-22 04:30:35 PST
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 8 2010-01-22 12:20:45 PST
A false failure is concerning. Not sure what was up here.
Note You need to log in before you can comment on or make changes to this bug.