Bug 33034

Summary: [v8] Move world-specific state out of V8Proxy
Product: WebKit Reporter: Adam Barth <abarth>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: dglazkov, eric, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Description Flags
Patch none

Description Adam Barth 2009-12-29 18:08:07 PST
[v8] Move window-specific state out of V8Proxy
Comment 1 Adam Barth 2009-12-29 18:12:52 PST
Created attachment 45625 [details]
Comment 2 WebKit Review Bot 2009-12-29 18:18:02 PST
Attachment 45625 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/V8DOMWindowShell.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bindings/v8/V8DOMWindowShell.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bindings/v8/V8DOMWindowShell.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bindings/v8/V8DOMWindowShell.cpp:62:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bindings/v8/V8DOMWindowShell.cpp:288:  Use 0 instead of NULL.  [readability/null] [4]
Total errors found: 5
Comment 3 Adam Barth 2009-12-29 18:28:12 PST
Created attachment 45626 [details]
Comment 4 WebKit Review Bot 2009-12-29 18:33:53 PST
Attachment 45626 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/V8DOMWindowShell.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bindings/v8/V8DOMWindowShell.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2
Comment 5 Adam Barth 2009-12-29 18:36:57 PST
Style errors are false positives:
Comment 6 Eric Seidel (no email) 2009-12-29 23:51:00 PST
Comment on attachment 45626 [details]

I did not review the + lines careful as I assumed they were all copy code.  I did look carefully at the - lines however.

This looks sane to me.
Comment 7 Dimitri Glazkov (Google) 2009-12-30 08:38:42 PST
This looks pretty cool.
Comment 8 Adam Barth 2009-12-30 10:23:05 PST
Comment on attachment 45626 [details]

Clearing flags on attachment: 45626

Committed r52666: <http://trac.webkit.org/changeset/52666>
Comment 9 Adam Barth 2009-12-30 10:23:13 PST
All reviewed patches have been landed.  Closing bug.