Bug 33009

Summary: Need a script to assign bugs with r+ patches to committers for landing
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 32995    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Eric Seidel (no email)
Reported 2009-12-28 22:43:45 PST
Need a script to assign bugs with r+ patches to committers for landing Many bugs get landed, and committers forget to close them. Or patches get posted and r+'d and committers forget about them. We need a script to at least handle the one-time reminder of assigning a bug to a committer for landing. That also makes it easier to see which bugs do not belong to committers in: http://webkit.org/pending-commit I've written a bugzilla-tool command do do this and will attach a patch.
Attachments
Patch (7.21 KB, patch)
2009-12-28 22:48 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (16.90 KB, patch)
2009-12-29 20:32 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-12-28 22:48:55 PST
Created attachment 45587 [details] Patch
Eric Seidel (no email)
Comment 2 2009-12-28 22:49:27 PST
This can't be commit-queue'd until bug 32995 is landed.
Adam Barth
Comment 3 2009-12-29 11:03:38 PST
Comment on attachment 45587 [details] Patch + FIXME: This can be removed once Command understands help_text like AbstractSequencedCommmand does You're looking for DeclarativeCommand, which knows how to do this. + reviwed_patches Typo + Bug %s likely needs commit-queue I'd make this a link for easy clickability. R- because you didn't add any tests!
Eric Seidel (no email)
Comment 4 2009-12-29 20:32:22 PST
Created attachment 45634 [details] Patch
WebKit Review Bot
Comment 5 2009-12-29 20:32:54 PST
style-queue ran check-webkit-style on attachment 45634 [details] without any errors.
Adam Barth
Comment 6 2009-12-29 20:40:03 PST
Comment on attachment 45634 [details] Patch ship it!
WebKit Commit Bot
Comment 7 2009-12-29 20:48:09 PST
Comment on attachment 45634 [details] Patch Clearing flags on attachment: 45634 Committed r52641: <http://trac.webkit.org/changeset/52641>
WebKit Commit Bot
Comment 8 2009-12-29 20:48:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.