Summary: | Add the start of a Bug object for bugzilla.py | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 33009 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2009-12-28 14:34:21 PST
Created attachment 45578 [details]
Patch
style-queue ran check-webkit-style on attachment 45578 [details] without any errors.
Comment on attachment 45578 [details]
Patch
Certainly not the last word, but progress nonetheless.
W.r.t. not all the steps having "Step" in their names: that's just a mistake. We should put them into a step module and call then step.Commit and step.EnsureBuildersAreGreen. The "build" in buildsteps is a misnomer now.
Comment on attachment 45578 [details] Patch Rejecting patch 45578 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests Testing 11854 test cases. fast/css/non-standard-checkbox-size.html -> failed Exiting early after 1 failures. 5218 tests run. 76.31s total testing time 5217 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/150775 Comment on attachment 45578 [details] Patch Sorry. We were bit by bug 28603. I've fixed the commit bot for now. Comment on attachment 45578 [details] Patch Clearing flags on attachment: 45578 Committed r52628: <http://trac.webkit.org/changeset/52628> All reviewed patches have been landed. Closing bug. |