| Summary: | upstream various forms tests | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||||
| Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | adele, bweinstein, commit-queue, eric, krackguy, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dirk Pranke
2009-12-18 16:34:05 PST
Created attachment 45207 [details]
Patch
Created attachment 45212 [details]
Patch
style-queue ran check-webkit-style on attachment 45212 [details] without any errors.
Comment on attachment 45212 [details]
Patch
I'm confused from the diff as to if this is just adding new tests or modifying existing ones.
this adds seven new tests upstream. Comment on attachment 45212 [details]
Patch
OK.
Comment on attachment 45212 [details] Patch Rejecting patch 45212 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe svnlook: Can't write to stream: Broken pipe The following files contain tab characters: trunk/LayoutTests/fast/forms/style-display-none.html Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://webkit-commit-queue.appspot.com/results/138484 Created attachment 45402 [details]
Patch
Comment on attachment 45402 [details]
Patch
OK.
Comment on attachment 45402 [details] Patch Clearing flags on attachment: 45402 Committed r52502: <http://trac.webkit.org/changeset/52502> All reviewed patches have been landed. Closing bug. Comment on attachment 45402 [details]
Patch
Eek! The ChangeLog was compeltely wrong here. My fault for not catching it.
I landed platform specific results for Windows for basic-textarea-quirks in r52533. It would be nice if someone could let me know if this is expected different behavior or if this is a bug. (In reply to comment #13) > I landed platform specific results for Windows for basic-textarea-quirks in > r52533. It would be nice if someone could let me know if this is expected > different behavior or if this is a bug. I would expect the windows results to be different from the mac results. Does that answer your question? (In reply to comment #14) > (In reply to comment #13) > > I landed platform specific results for Windows for basic-textarea-quirks in > > r52533. It would be nice if someone could let me know if this is expected > > different behavior or if this is a bug. > > I would expect the windows results to be different from the mac results. Does > that answer your question? Yeah, thanks! *** Bug 22656 has been marked as a duplicate of this bug. *** |