Bug 32755

Summary:

upstream various forms tests

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Tools / Tests

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele, bweinstein, commit-queue, eric, krackguy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Dirk Pranke

Reported 2009-12-18 16:34:05 PST

Upstreaming a bunch of forms tests from chromium.org

Attachments
Patch (122.52 KB, patch) 2009-12-18 16:34 PST, Dirk Pranke	no flags	Details Formatted Diff Diff
Patch (473.24 KB, patch) 2009-12-18 16:53 PST, Dirk Pranke	no flags	Details Formatted Diff Diff
Patch (473.71 KB, patch) 2009-12-22 14:03 PST, Dirk Pranke	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2009-12-18 16:34:54 PST

Created attachment 45207 [details] Patch

Dirk Pranke

Comment 2 2009-12-18 16:53:29 PST

Created attachment 45212 [details] Patch

WebKit Review Bot

Comment 3 2009-12-18 16:54:59 PST

style-queue ran check-webkit-style on attachment 45212 [details] without any errors.

Eric Seidel (no email)

Comment 4 2009-12-19 12:23:14 PST

Comment on attachment 45212 [details] Patch I'm confused from the diff as to if this is just adding new tests or modifying existing ones.

Dirk Pranke

Comment 5 2009-12-21 14:22:00 PST

this adds seven new tests upstream.

Eric Seidel (no email)

Comment 6 2009-12-22 13:24:53 PST

Comment on attachment 45212 [details] Patch OK.

WebKit Commit Bot

Comment 7 2009-12-22 13:51:42 PST

Comment on attachment 45212 [details] Patch Rejecting patch 45212 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe svnlook: Can't write to stream: Broken pipe The following files contain tab characters: trunk/LayoutTests/fast/forms/style-display-none.html Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://webkit-commit-queue.appspot.com/results/138484

Dirk Pranke

Comment 8 2009-12-22 14:03:08 PST

Created attachment 45402 [details] Patch

Eric Seidel (no email)

Comment 9 2009-12-22 14:05:35 PST

Comment on attachment 45402 [details] Patch OK.

WebKit Commit Bot

Comment 10 2009-12-22 14:26:30 PST

Comment on attachment 45402 [details] Patch Clearing flags on attachment: 45402 Committed r52502: <http://trac.webkit.org/changeset/52502>

WebKit Commit Bot

Comment 11 2009-12-22 14:26:36 PST

All reviewed patches have been landed. Closing bug.

Eric Seidel (no email)

Comment 12 2009-12-22 14:37:40 PST

Comment on attachment 45402 [details] Patch Eek! The ChangeLog was compeltely wrong here. My fault for not catching it.

Brian Weinstein

Comment 13 2009-12-23 16:35:30 PST

I landed platform specific results for Windows for basic-textarea-quirks in r52533. It would be nice if someone could let me know if this is expected different behavior or if this is a bug.

Dirk Pranke

Comment 14 2009-12-28 12:19:06 PST

(In reply to comment #13) > I landed platform specific results for Windows for basic-textarea-quirks in > r52533. It would be nice if someone could let me know if this is expected > different behavior or if this is a bug. I would expect the windows results to be different from the mac results. Does that answer your question?

Brian Weinstein

Comment 15 2009-12-28 12:39:15 PST

(In reply to comment #14) > (In reply to comment #13) > > I landed platform specific results for Windows for basic-textarea-quirks in > > r52533. It would be nice if someone could let me know if this is expected > > different behavior or if this is a bug. > > I would expect the windows results to be different from the mac results. Does > that answer your question? Yeah, thanks!

Alexey Proskuryakov

Comment 16 2010-04-26 19:10:56 PDT

*** Bug 22656 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.