Bug 32343
| Summary: | commit-queue should reject/handle patches missing Reviewed by line | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | 26927 | ||
| Bug Blocks: | |||
Eric Seidel (no email)
commit-queue should reject/handle patches missing Reviewed by line
If contributors delete the "Reviewed by" line then the commit-queue will happily land a patch w/o listing the reviewer in the ChangeLog. This is bad. :(
http://trac.webkit.org/changeset/51910
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
Bug 32940 is another example of where this would be useful.