Bug 32042

Summary: style-queue (or something) should r- patches missing ChangeLogs
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: abarth, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   

Description Eric Seidel (no email) 2009-12-01 17:16:46 PST
style-queue (or something) should r- patches missing ChangeLogs

Or at least make a nasty comment in the bug.  Rarely can one actually review a patch w/o a ChangeLog.

We have at least one other bug about our tools warning us sooner, but if style-queue is the earliest we can get a warning, then so be it.  It's better than the current pre-commit hook or reviewers spending time on it.

The bot should point people to http://webkit.org/coding/contributing.html or possibly http://webkit.org/coding/contributing.html#changelogs
Comment 1 Alexey Proskuryakov 2009-12-02 10:48:48 PST
A helpful comment would be OK, but you'd need to nominate the tool for reviewer status to actually r-. 

And there are cases when it makes more sense to just manually adapt and land a one time contributor's patch than to educate them about our process. Sometimes people do useful things without long-term involvement with the project.
Comment 2 Alexey Proskuryakov 2013-03-25 13:46:23 PDT
*** Bug 61458 has been marked as a duplicate of this bug. ***
Comment 3 Alexey Proskuryakov 2013-03-25 13:46:42 PDT
*** Bug 62021 has been marked as a duplicate of this bug. ***