Bug 32002
| Summary: | Bug in custom JS bindings for texImage2D and texSubImage2D | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Russell <kbr> |
| Component: | WebGL | Assignee: | Kenneth Russell <kbr> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | brettw, cmarrin, oliver, petersont, rlp |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Kenneth Russell
I happened to notice via code inspection that the flipY and premultiplyAlpha boolean values are being set from the same incoming argument in the custom JS bindings for texImage2D and texSubImage2D. The errors are around lines 377-378 and 413-414 in WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp. I'm not sure whether GraphicsContext3DMac.cpp is supposed to handle the flipY argument properly yet, but if it is then this is probably why it isn't taking effect.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Oliver Hunt
(In reply to comment #0)
> I happened to notice via code inspection that the flipY and premultiplyAlpha
> boolean values are being set from the same incoming argument in the custom JS
> bindings for texImage2D and texSubImage2D. The errors are around lines 377-378
> and 413-414 in WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp. I'm not
> sure whether GraphicsContext3DMac.cpp is supposed to handle the flipY argument
> properly yet, but if it is then this is probably why it isn't taking effect.
irk, what i would give for autogen of variadic functions... :-/
Kenneth Russell
This was implicitly fixed in the deletion of the custom JSC bindings for texImage2D in bug 40443.
*** This bug has been marked as a duplicate of bug 40443 ***