Bug 31924

Summary:

ResourceHandle has virtual methods but non-virtual destructor

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Steve Block <steveblock>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

ap, eric, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch 1 for Bug 31924	eric: review+, steveblock: commit-queue-

Steve Block

Reported 2009-11-27 03:39:42 PST

ResourceHandle has virtual methods but a non-virtual destructor. This can cause build warnings or errors. These virtual methods were added in http://trac.webkit.org/changeset/50772.

Attachments
Patch 1 for Bug 31924 (1.12 KB, patch) 2009-11-27 03:45 PST, Steve Block	eric: review+ steveblock: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2009-11-27 03:45:06 PST

Created attachment 43940 [details] Patch 1 for Bug 31924

Eric Seidel (no email)

Comment 2 2009-11-28 09:30:29 PST

Comment on attachment 43940 [details] Patch 1 for Bug 31924 OK.

Eric Seidel (no email)

Comment 3 2009-11-28 09:31:47 PST

Please CC the folks who made the change when making a build fix. :) http://trac.webkit.org/changeset/50772

Steve Block

Comment 4 2009-11-30 08:54:40 PST

Already fixed in https://bugs.webkit.org/show_bug.cgi?id=31962, which was filed after this bug, but made it into the commit queue first.

Steve Block

Comment 5 2009-11-30 08:55:08 PST

*** This bug has been marked as a duplicate of bug 31962 ***

Note You need to log in before you can comment on or make changes to this bug.