Bug 31872

Summary: centralize required argument parsing in Command
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Centralize required argument parsing abarth: review+, abarth: commit-queue-

Description Eric Seidel (no email) 2009-11-25 07:14:12 PST
centralize required argument parsing in Command
Comment 1 Eric Seidel (no email) 2009-11-25 07:23:28 PST
Created attachment 43842 [details]
Centralize required argument parsing
Comment 2 Adam Barth 2009-11-25 07:32:47 PST
Comment on attachment 43842 [details]
Centralize required argument parsing

me: self.assertRaises(Exception, Command._parse_required_arguments, "[ARG1 ARG2]")
i guess that's ok

eric: I can make it smarter to handle that sort of thing
but for now I wanted to document that we didn't expect that to work

me: yeah, probably should add a comment that we might want to accept that case in the future
Comment 3 Eric Seidel (no email) 2009-11-25 07:34:50 PST
Will land once bug 31870 is in.
Comment 4 Eric Seidel (no email) 2009-11-25 08:05:51 PST
Committed r51383: <http://trac.webkit.org/changeset/51383>