Bug 31872

Summary:

centralize required argument parsing in Command

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Centralize required argument parsing	abarth: review+, abarth: commit-queue-

Eric Seidel (no email)

Reported 2009-11-25 07:14:12 PST

centralize required argument parsing in Command

Attachments
Centralize required argument parsing (9.65 KB, patch) 2009-11-25 07:23 PST, Eric Seidel (no email)	abarth: review+ abarth: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-11-25 07:23:28 PST

Created attachment 43842 [details] Centralize required argument parsing

Adam Barth

Comment 2 2009-11-25 07:32:47 PST

Comment on attachment 43842 [details] Centralize required argument parsing me: self.assertRaises(Exception, Command._parse_required_arguments, "[ARG1 ARG2]") i guess that's ok eric: I can make it smarter to handle that sort of thing but for now I wanted to document that we didn't expect that to work me: yeah, probably should add a comment that we might want to accept that case in the future

Eric Seidel (no email)

Comment 3 2009-11-25 07:34:50 PST

Will land once bug 31870 is in.

Eric Seidel (no email)

Comment 4 2009-11-25 08:05:51 PST

Committed r51383: <http://trac.webkit.org/changeset/51383>

Note You need to log in before you can comment on or make changes to this bug.