Summary: | Rename CanvasObject to WebGLObject | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||
Component: | WebGL | Assignee: | Kenneth Russell <kbr> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | cmarrin, dglazkov, mdelaney7, oliver, webkit.review.bot, zmo | ||||
Priority: | P3 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Kenneth Russell
2009-11-16 14:24:40 PST
Created attachment 63503 [details]
Patch
From the ChangeLog:
Renamed CanvasObject to WebGLObject using do-webcore-rename script. Because it seems the new convention is to not check in the changes made to this script, only checking in its effects. No new tests; built and ran WebGL in Safari and Chromium to test.
Comment on attachment 63503 [details]
Patch
rs=me.
Attachment 63503 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/html/canvas/CanvasRenderingContext.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebCore/html/canvas/WebGLProgram.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebCore/html/canvas/WebGLBuffer.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebCore/html/canvas/WebGLFramebuffer.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebCore/html/canvas/WebGLRenderbuffer.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebCore/html/canvas/WebGLTexture.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebCore/html/canvas/WebGLObject.cpp:30: You should add a blank line after implementation file's own header. [build/include_order] [4]
WebCore/html/canvas/WebGLShader.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 8 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Note: preexisting style violations in these files will be cleaned up in https://bugs.webkit.org/show_bug.cgi?id=38761 . Committed r64685: <http://trac.webkit.org/changeset/64685> |