Bug 31564

Summary: Rename CanvasObject to WebGLObject
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Minor CC: cmarrin, dglazkov, mdelaney7, oliver, webkit.review.bot, zmo
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch dglazkov: review+, kbr: commit-queue-

Kenneth Russell
Reported 2009-11-16 14:24:40 PST
The CanvasObject type isn't exposed in the public WebGL API, but it is used throughout the implementation. Per https://bugs.webkit.org/show_bug.cgi?id=29095 it should be renamed to WebGLObject and all of the subclasses updated.
Attachments
Patch (42.53 KB, patch)
2010-08-04 15:39 PDT, Kenneth Russell
dglazkov: review+
kbr: commit-queue-
Kenneth Russell
Comment 1 2010-08-04 15:39:39 PDT
Created attachment 63503 [details] Patch From the ChangeLog: Renamed CanvasObject to WebGLObject using do-webcore-rename script. Because it seems the new convention is to not check in the changes made to this script, only checking in its effects. No new tests; built and ran WebGL in Safari and Chromium to test.
Dimitri Glazkov (Google)
Comment 2 2010-08-04 15:41:40 PDT
Comment on attachment 63503 [details] Patch rs=me.
WebKit Review Bot
Comment 3 2010-08-04 15:42:35 PDT
Attachment 63503 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/html/canvas/CanvasRenderingContext.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4] WebCore/html/canvas/WebGLProgram.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] WebCore/html/canvas/WebGLBuffer.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] WebCore/html/canvas/WebGLFramebuffer.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] WebCore/html/canvas/WebGLRenderbuffer.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] WebCore/html/canvas/WebGLTexture.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] WebCore/html/canvas/WebGLObject.cpp:30: You should add a blank line after implementation file's own header. [build/include_order] [4] WebCore/html/canvas/WebGLShader.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 8 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kenneth Russell
Comment 4 2010-08-04 15:45:28 PDT
Note: preexisting style violations in these files will be cleaned up in https://bugs.webkit.org/show_bug.cgi?id=38761 .
Kenneth Russell
Comment 5 2010-08-04 15:49:19 PDT
Note You need to log in before you can comment on or make changes to this bug.