Bug 31516

Summary: Need to implement ARIA role="directory"
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
patch darin: review+

Description chris fleizach 2009-11-14 20:17:28 PST
The ARIA spec defines the directory role as "A list of references to members of a single group."
Comment 1 chris fleizach 2009-11-14 20:30:40 PST
Created attachment 43238 [details]
patch
Comment 2 chris fleizach 2009-11-14 20:31:27 PST
Comment on attachment 43238 [details]
patch

some reason there was an xcodeproj change
Comment 3 chris fleizach 2009-11-14 20:38:04 PST
Created attachment 43239 [details]
patch
Comment 4 Darin Adler 2009-11-15 17:04:04 PST
Comment on attachment 43239 [details]
patch

> +        * accessibility/AccessibilityObject.h:
> +        (WebCore::):

> +        * accessibility/mac/AccessibilityObjectWrapper.mm:
> +        (RoleEntry::):

These change log entries are wrong. If the script makes a bad entry like this you should just delete it before posting the patch.

I should fix prepare-ChangeLog so it never does that. A function name can never just end in "::" so I can work around the bug pretty easily.

>      TabPanelRole,
>      TreeRole,
>      TreeItemRole,
> +    DirectoryRole,

Can we keep these in alphabetical order?

> -        return UI_STRING("tab panel", "An ARIA accessibility group that contenst the content of a tab.");
> +        return UI_STRING("tab panel", "An ARIA accessibility group that contains the content of a tab.");

You need to regenerate the strings file after making a change like this one.
Comment 5 chris fleizach 2009-11-15 17:51:48 PST
> >      TabPanelRole,
> >      TreeRole,
> >      TreeItemRole,
> > +    DirectoryRole,
> 
> Can we keep these in alphabetical order?
> 

Re-ordering those items will be a rather big change. i filed
https://bugs.webkit.org/show_bug.cgi?id=31524
to take care of that
Comment 6 chris fleizach 2009-11-15 18:06:25 PST
http://trac.webkit.org/changeset/51007