Bug 31516 – Need to implement ARIA role="directory"

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

The ARIA spec defines the directory role as "A list of references to members of a single group."

[chris fleizach]

Created attachment 43238 [details]
patch

[chris fleizach]

Comment on attachment 43238 [details]
patch

some reason there was an xcodeproj change

[chris fleizach]

Created attachment 43239 [details]
patch

[Darin Adler]

Comment on attachment 43239 [details]
patch

> +        * accessibility/AccessibilityObject.h:
> +        (WebCore::):

> +        * accessibility/mac/AccessibilityObjectWrapper.mm:
> +        (RoleEntry::):

These change log entries are wrong. If the script makes a bad entry like this you should just delete it before posting the patch.

I should fix prepare-ChangeLog so it never does that. A function name can never just end in "::" so I can work around the bug pretty easily.

>      TabPanelRole,
>      TreeRole,
>      TreeItemRole,
> +    DirectoryRole,

Can we keep these in alphabetical order?

> -        return UI_STRING("tab panel", "An ARIA accessibility group that contenst the content of a tab.");
> +        return UI_STRING("tab panel", "An ARIA accessibility group that contains the content of a tab.");

You need to regenerate the strings file after making a change like this one.

[chris fleizach]

> >      TabPanelRole,
> >      TreeRole,
> >      TreeItemRole,
> > +    DirectoryRole,
> 
> Can we keep these in alphabetical order?
> 

Re-ordering those items will be a rather big change. i filed
https://bugs.webkit.org/show_bug.cgi?id=31524
to take care of that

[chris fleizach]

http://trac.webkit.org/changeset/51007