Bug 31490

Summary: Allow building Chromium without SVG
Product: WebKit Reporter: Evan Martin <evan>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Minor CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
patch that is correct regardless of this bug
none
wip patch
none
wrap some code with ENABLE(SVG) none

Evan Martin
Reported 2009-11-13 14:02:51 PST
I don't use SVG in my day-to-day debugging and it's a bunch of extra code for the compiler, linker, etc. to move around. I measured it at around 14.5% of the resulting binary size of a Debug build. We should allow building without SVG.
Attachments
patch that is correct regardless of this bug (933 bytes, patch)
2009-11-13 14:04 PST, Evan Martin 		no flags
DetailsFormatted DiffDiff
wip patch (3.72 KB, patch)
2009-11-13 14:05 PST, Evan Martin 		no flags
DetailsFormatted DiffDiff
wrap some code with ENABLE(SVG) (1.38 KB, patch)
2009-11-13 14:07 PST, Evan Martin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Evan Martin
Comment 1 2009-11-13 14:04:59 PST
Created attachment 43195 [details] patch that is correct regardless of this bug
Evan Martin
Comment 2 2009-11-13 14:05:31 PST
Created attachment 43196 [details] wip patch
Evan Martin
Comment 3 2009-11-13 14:07:43 PST
Created attachment 43197 [details] wrap some code with ENABLE(SVG)
Adam Barth
Comment 4 2009-11-15 15:29:40 PST
Comment on attachment 43197 [details] wrap some code with ENABLE(SVG) Clearing flags on attachment: 43197 Committed r51004: <http://trac.webkit.org/changeset/51004>
Adam Barth
Comment 5 2009-11-15 15:29:46 PST
All reviewed patches have been landed. Closing bug.
Evan Martin
Comment 6 2009-11-15 16:10:09 PST
still not done
Adam Barth
Comment 7 2009-11-15 16:40:24 PST
(In reply to comment #6) > still not done Please use a new bug. We try to use one patch per bug. You can create a meta bug if you think people would like to track all the patches.
Evan Martin
Comment 8 2009-11-15 16:41:19 PST
The patch you committed for me does not let us bulid without SVG; it was just the part of the patch I'd written that was inarguably correct.
Adam Barth
Comment 9 2009-11-15 16:46:38 PST
What's the cost of making a new bug? I'm the only person on the CC list of this bug. If you create a new bug, then people trying to understand that patch will be saved from trying to understand the 9+ comments on this bug. If you'd like to see how the project manages a task that requires lots of patches, one example is <https://bugs.webkit.org/show_bug.cgi?id=29947>.
Evan Martin
Comment 10 2009-11-15 17:09:50 PST
ok https://bugs.webkit.org/show_bug.cgi?id=31522
Note You need to log in before you can comment on or make changes to this bug.