Bug 313791
| Summary: | REGRESSION(312305@main): [macOS] 5 http/tests/inspector tests are constant TIMEOUTs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | New Bugs | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=313792 | ||
Brent Fulgham
The changes in Bug 313025 seems to have introduced a bot incremental build issue on some machines. The stamp file in DERIVED_FILE_DIR (build intermediates) persists across builds, but the products directory gets cleaned. Xcode sees the stamp is newer than all inputs, skips the phase, and the inspector resources are never copied.
This change adds a check that at least one of the WebInspectorUI product files is present in the output file location so that the copy phase will happen, even if the stamp file indicates that no changes were made to the contents of the WebInspectorUI files.
This problem is unique to the WebInspectorUI project.
<rdar://175978103>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/64014
EWS
Committed 312412@main (d26734e26f72): <https://commits.webkit.org/312412@main>
Reviewed commits have been landed. Closing PR #64014 and removing active labels.
Brent Fulgham
Reopening: This change dealt with a *different* build problem.
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/64052
EWS
Committed 312450@main (8fdb43bdab38): <https://commits.webkit.org/312450@main>
Reviewed commits have been landed. Closing PR #64052 and removing active labels.