Bug 313792 – [EWS] clean-build doesn't remove intermediate files

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: Tools / Tests

[Elliott Williams]

The clean-build step run by buildbot is misleading. It's labeled "delete WebKitBuild directory" in the UI, but the script it runs (Tools/CISupport/clean-build) looks up the *products* directory for the current platform, and deletes that. So for example, an iOS device release builder removes:

    WebKitBuild/Release-iphoneos

What it should really do is remove the intermediates, too. This could be done with a command like:

    rm WebKitBuild/{,*.build/}Release-iphoneos

Or we could just delete the whole build directory like we advertise, since we do not have any multi-platform builders.

[Radar WebKit Bug Importer]

<rdar://problem/176046546>

[Alexey Proskuryakov]

Pull request: https://github.com/WebKit/WebKit/pull/64064

[Elliott Williams]

I misjudged what this script is doing, and my report was based on bad evidence. It's actually passing --top-level to `webkit-build-directory`, so it _does_ delete the whole build dir. For example:

```
emw@aria2 ~/wk2> ls WebKitBuild
ANGLE.build/                     JavaScriptCore.build/            SwiftBrowser.build/              WebKitLegacy.build/
bmalloc.build/                   libwebrtc.build/                 SwiftExplicitPrecompiledModules/ WebKitTestRunner.build/
dav1d.build/                     lldbWebKitTester.build/          TestWebKitAPI.build/             WTF.build/
DumpRenderTree.build/            MiniBrowser.build/               WebCore.build/                   XCBuildData/
EagerLinkingTBDs/                PAL.build/                       WebGPU.build/
ExplicitPrecompiledModules/      PrecompiledHeaders/              WebInspectorUI.build/
gtest.build/                     Release/                         WebKit.build/

emw@aria2 ~/wk2> python3 Tools/CISupport/clean-build --platform=mac-tahoe --release

emw@aria2 ~/wk2> ls WebKitBuild
ls: WebKitBuild: No such file or directory
```