Summary: | [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726). | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vitaly Repeshko <vitalyr> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dglazkov, eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 31200 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Vitaly Repeshko
2009-11-10 09:24:47 PST
Created attachment 42874 [details]
patch:layout test and fix
Comment on attachment 42874 [details] patch:layout test and fix > // XPath-related utilities > - static RefPtr<XPathNSResolver> getXPathNSResolver(v8::Handle<v8::Value> value) > + static RefPtr<XPathNSResolver> getXPathNSResolver(v8::Handle<v8::Value> value, V8Proxy* proxy=0) proxy = 0 otherwise, r=me. Created attachment 42875 [details]
patch: layout test and fix v2
(In reply to comment #2) > (From update of attachment 42874 [details]) > > // XPath-related utilities > > - static RefPtr<XPathNSResolver> getXPathNSResolver(v8::Handle<v8::Value> value) > > + static RefPtr<XPathNSResolver> getXPathNSResolver(v8::Handle<v8::Value> value, V8Proxy* proxy=0) > > proxy = 0 > > otherwise, r=me. Done. Thanks. Comment on attachment 42875 [details]
patch: layout test and fix v2
r=me. Hope the test expectations aren't generated on Chromium, like the last time ;)
Comment on attachment 42875 [details]
patch: layout test and fix v2
Rejecting patch 42875 from commit-queue.
Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11584 test cases.
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html -> failed
Exiting early after 1 failures. 9001 tests run.
251.94s total testing time
9000 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
5 test cases (<1%) had stderr output
Comment on attachment 42875 [details]
patch: layout test and fix v2
spin again.
I've filed bug 31305 about the failure. You should feel encouraged to file bugs about mysterious cq failures if you ever see them. Comment on attachment 42875 [details]
patch: layout test and fix v2
Rejecting patch 42875 from commit-queue.
Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11584 test cases.
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html -> failed
Exiting early after 1 failures. 9001 tests run.
246.13s total testing time
9000 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
5 test cases (<1%) had stderr output
Comment on attachment 42875 [details] patch: layout test and fix v2 Clearing flags on attachment: 42875 Committed r50785: <http://trac.webkit.org/changeset/50785> All reviewed patches have been landed. Closing bug. |