Bug 31294
| Summary: | [Qt] Font selection of generic fonts is broken | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Hausmann <hausmann> |
| Component: | Text | Assignee: | Tor Arne Vestbø <vestbo> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mike, vestbo |
| Priority: | P3 | Keywords: | Qt |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | OS X 10.5 | ||
Simon Hausmann
The Qt port does not correctly choose the fonts specified in HTML/CSS.
This is a placeholder bug that we classify as showstopper for Qt 4.6.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tor Arne Vestbø
In FontCache::getCachedFontPlatformData() we ignore the family argument which contains the resolved real font family from the web settings, and instead we pass on the generic font family to Qt.
See also http://www.w3.org/TR/CSS2/fonts.html#generic-font-families
Quick fix here: http://gist.github.com/230871
Will try patch against 4.5 first to not mess up the buildbot too much.
Simon Hausmann
I believe this may be the same as bug #22896
Jocelyn Turcotte
*** Bug 22896 has been marked as a duplicate of this bug. ***
Tor Arne Vestbø
This was fixed in r51758
Jocelyn Turcotte
*** Bug 29458 has been marked as a duplicate of this bug. ***