Summary: | [Qt] QWebPage::createPlugin() ignores visibility attribute in 4.5 | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Nichols <andy.nichols> | ||||||||||||||
Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | benjamin, dglazkov, jturcotte, kenneth, laszlo.gombos, vestbo, zecke | ||||||||||||||
Priority: | P2 | Keywords: | Qt | ||||||||||||||
Version: | 420+ | ||||||||||||||||
Hardware: | PC | ||||||||||||||||
OS: | All | ||||||||||||||||
Attachments: |
|
Description
Andy Nichols
2009-11-06 05:09:17 PST
Created attachment 42645 [details]
Test Case
Created attachment 43127 [details]
Fix the cause of this bug
WebCore::Widget was handling show/hide properly but the QtPluginWidget::frameRectChanged was calling setVisible undoing the effect of show/hide.
Comment on attachment 43127 [details]
Fix the cause of this bug
We have some manual-tests. Have you run those? Especially for testing the clipping. Also, doesn't WebCore::Widget have code for knowing if it is visible or not, that can be used instead of m_visible?
Comment on attachment 43127 [details]
Fix the cause of this bug
Patch has been cherry-picked into Qt 4.6, but zecke will redo it for inclusion in trunk.
The test will be turned into a real layout test and the code will make use of setSelfVisible from WebCore::Widget.
Created attachment 43712 [details]
Move PluginViewQt.cpp PluginView::show/::hide to Widget::show/::hide
Fix the bug by making use of Widget::isVisible, isSelfVisible, isParentVisible... Update the manual test to include the problem seen here.
Created attachment 43713 [details]
Be able to automate tests including a QWidget
Print the QWidget properties as part of the RenderPart. This will require us to update some results but I have hundreds of test failures locally (by default...)
Is this supposed to be up for review? Comment on attachment 43712 [details]
Move PluginViewQt.cpp PluginView::show/::hide to Widget::show/::hide
Test cases are passing...
Created attachment 43756 [details]
Be able to automate plugin tests using a QWidget
Add new test, test result, update the other existing result
Comment on attachment 43756 [details]
Be able to automate plugin tests using a QWidget
Great work.
Please remove 'Need a short description and bug URL (OOPS!)' from the ChangeLog
Should we be testing QGraphicsWidget based plugins as well? might widget in those cases be a QGrapicsWidget and not a QWidget?
Created attachment 43805 [details]
Be able to automate plugin test using a QWidget -- Fix the ChangeLog entry
Fix the ChangeLog entry, regarding the QGraphicsView and Qt plugins. I don't know yet.
Shouldn't the test have gone to platform/gt/plugins instead of just plugins? (In reply to comment #13) > Shouldn't the test have gone to platform/gt/plugins instead of just plugins? For me it looked to be in the same class as the ObjC plugins that are in the plugin directory as well. We can consider moving all those away though. *** Bug 29451 has been marked as a duplicate of this bug. *** I waited for Dimitri to respond to my response. If Dimitri thinks there should be more work done we can reopen the bug again, for now closing is the most easy way to make it drop out of the review queue. *** Bug 35670 has been marked as a duplicate of this bug. *** |