|Summary:||Need a way to validate that committers.py includes all committers/reviewers|
|Product:||WebKit||Reporter:||Eric Seidel (no email) <eric>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||adele, commit-queue, vestbo|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
|Bug Depends on:||31046, 31037, 31364, 31366|
Description Eric Seidel (no email) 2009-10-30 17:13:05 PDT
Need a way to validate that committers.py includes all committers/reviewers Here is a first stab. I'm not sure we'd ever commit this, but it's been useful so far. I've written a script to validate against the lists.webkit.org mailing lists. I know of no way to validate against the svn.webkit.org list. Looks like we have a bunch of out-of-date accounts on the lists.webkit.org lists.
Comment 1 Eric Seidel (no email) 2009-11-02 17:34:12 PST
Created attachment 42351 [details] First attempt, will need to be reviewed in pieces
Comment 2 Eric Seidel (no email) 2009-11-02 17:36:58 PST
Created attachment 42352 [details] Example output from the script Someone at Apple who actually has access to the official committer and reviewer list will need to use the output of this tool to validate those lists against what SVN history shows, what the mailing lists show, and what committers.py shows. At least the two externally visible lists will likely need modification.
Comment 3 Tor Arne Vestbø 2009-11-03 06:31:16 PST
Cool stuff :)
Comment 5 Adam Barth 2009-11-12 20:53:08 PST
Comment on attachment 42989 [details] Patch + os.system("open \"" + user_lookup_url + email + "\"") This is a giant security vulnerability!
Comment 6 Eric Seidel (no email) 2009-11-13 16:52:39 PST
Created attachment 43214 [details] Remove the troublesome code
Comment 7 Adam Barth 2009-11-29 18:01:34 PST
Comment on attachment 43214 [details] Remove the troublesome code I didn't follow all of the logic, but this looks great. You're python regexp foo >> mine. :)
Comment 8 Eric Seidel (no email) 2009-11-29 18:21:57 PST
Comment on attachment 43214 [details] Remove the troublesome code I'm happy to explain any of it of course.
Comment 9 WebKit Commit Bot 2009-11-29 19:12:20 PST
Comment on attachment 43214 [details] Remove the troublesome code Clearing flags on attachment: 43214 Committed r51475: <http://trac.webkit.org/changeset/51475>
Comment 10 WebKit Commit Bot 2009-11-29 19:12:26 PST
All reviewed patches have been landed. Closing bug.