Bug 30970

Summary:

Need a way to validate that committers.py includes all committers/reviewers

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele, commit-queue, vestbo

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

31046, 31037, 31364, 31366

Bug Blocks:

Attachments:

Description	Flags
First attempt, will need to be reviewed in pieces	none
Example output from the script	none
Patch	none
Remove the troublesome code	none

Eric Seidel (no email)

Reported 2009-10-30 17:13:05 PDT

Need a way to validate that committers.py includes all committers/reviewers Here is a first stab. I'm not sure we'd ever commit this, but it's been useful so far. I've written a script to validate against the lists.webkit.org mailing lists. I know of no way to validate against the svn.webkit.org list. Looks like we have a bunch of out-of-date accounts on the lists.webkit.org lists.

Attachments
First attempt, will need to be reviewed in pieces (26.09 KB, patch) 2009-11-02 17:34 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Example output from the script (3.97 KB, text/plain) 2009-11-02 17:36 PST, Eric Seidel (no email)	no flags	Details
Patch (14.58 KB, patch) 2009-11-11 12:17 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Remove the troublesome code (14.11 KB, patch) 2009-11-13 16:52 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-11-02 17:34:12 PST

Created attachment 42351 [details] First attempt, will need to be reviewed in pieces

Eric Seidel (no email)

Comment 2 2009-11-02 17:36:58 PST

Created attachment 42352 [details] Example output from the script Someone at Apple who actually has access to the official committer and reviewer list will need to use the output of this tool to validate those lists against what SVN history shows, what the mailing lists show, and what committers.py shows. At least the two externally visible lists will likely need modification.

Tor Arne Vestbø

Comment 3 2009-11-03 06:31:16 PST

Cool stuff :)

Eric Seidel (no email)

Comment 4 2009-11-11 12:17:35 PST

Created attachment 42989 [details] Patch

Adam Barth

Comment 5 2009-11-12 20:53:08 PST

Comment on attachment 42989 [details] Patch + os.system("open \"" + user_lookup_url + email + "\"") This is a giant security vulnerability!

Eric Seidel (no email)

Comment 6 2009-11-13 16:52:39 PST

Created attachment 43214 [details] Remove the troublesome code

Adam Barth

Comment 7 2009-11-29 18:01:34 PST

Comment on attachment 43214 [details] Remove the troublesome code I didn't follow all of the logic, but this looks great. You're python regexp foo >> mine. :)

Eric Seidel (no email)

Comment 8 2009-11-29 18:21:57 PST

Comment on attachment 43214 [details] Remove the troublesome code I'm happy to explain any of it of course.

WebKit Commit Bot

Comment 9 2009-11-29 19:12:20 PST

Comment on attachment 43214 [details] Remove the troublesome code Clearing flags on attachment: 43214 Committed r51475: <http://trac.webkit.org/changeset/51475>

WebKit Commit Bot

Comment 10 2009-11-29 19:12:26 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.