Need a way to validate that committers.py includes all committers/reviewers

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Need a way to validate that committers.py includes all committers/reviewers

Here is a first stab.  I'm not sure we'd ever commit this, but it's been useful so far.

I've written a script to validate against the lists.webkit.org mailing lists.  I know of no way to validate against the svn.webkit.org list.

Looks like we have a bunch of out-of-date accounts on the lists.webkit.org lists.

[Eric Seidel (no email)]

Created attachment 42351 [details]
First attempt, will need to be reviewed in pieces

[Eric Seidel (no email)]

Created attachment 42352 [details]
Example output from the script

Someone at Apple who actually has access to the official committer and reviewer list will need to use the output of this tool to validate those lists against what SVN history shows, what the mailing lists show, and what committers.py shows.  At least the two externally visible lists will likely need modification.

[Tor Arne Vestbø]

Cool stuff :)

[Eric Seidel (no email)]

Created attachment 42989 [details]
Patch

[Adam Barth]

Comment on attachment 42989 [details]
Patch

+ os.system("open \"" + user_lookup_url + email + "\"")

This is a giant security vulnerability!

[Eric Seidel (no email)]

Created attachment 43214 [details]
Remove the troublesome code

[Adam Barth]

Comment on attachment 43214 [details]
Remove the troublesome code

I didn't follow all of the logic, but this looks great.  You're python regexp foo >> mine.  :)

[Eric Seidel (no email)]

Comment on attachment 43214 [details]
Remove the troublesome code

I'm happy to explain any of it of course.

[WebKit Commit Bot]

Comment on attachment 43214 [details]
Remove the troublesome code

Clearing flags on attachment: 43214

Committed r51475: <http://trac.webkit.org/changeset/51475>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.