Bug 30299

Summary:

Fix profile grouping in the Profiles panel sidebar tree

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pfeldman, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

30253

Attachments:

Description	Flags
patch	timothy: review+

Alexander Pavlov (apavlov)

Reported 2009-10-12 02:38:26 PDT

Currently, grouping of the profiles with the same title is broken Test case: In the Console, enter the following series of commands: console.profile('foo') console.profileEnd() console.profile('foo') console.profileEnd() The second profile node becomes a child of the first one's in the sidebar tree, while they should both become children named "Run N" of a new common parent node named "foo".

Attachments
patch (1.91 KB, patch) 2009-10-12 02:47 PDT, Alexander Pavlov (apavlov)	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2009-10-12 02:47:35 PDT

Created attachment 41028 [details] patch Use the right parent when adding a new group node to the sidebar tree.

Pavel Feldman

Comment 2 2009-10-13 01:20:04 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ProfilesPanel.js Committed r49494

Note You need to log in before you can comment on or make changes to this bug.