Summary: | Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> | ||||
Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, zecke | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Laszlo Gombos
2009-10-10 08:16:18 PDT
Created attachment 40993 [details]
first try
Comment on attachment 40993 [details]
first try
tools like bugzilla-tool post-diff and git-send-bugzilla will automatically check the "patch" checkbox for you during upload. Otherwise you'll need to do it yourself. :)
Comment on attachment 40993 [details]
first try
Nice cleanup :)
Comment on attachment 40993 [details]
first try
Rejecting patch 40993 from commit-queue.
Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Last 500 characters of output:
Queue/LayoutTests
Testing 11423 test cases.
http/tests/history/redirect-302.pl -> timed out
Sampling process 7317 for 10 seconds with 10 milliseconds of run time between samples
Sampling completed, processing symbols...
Sample analysis of process 7317 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt
Exiting early after 1 failures. 8478 tests run.
514.97s total testing time
8477 test cases (99%) succeeded
1 test case (<1%) timed out
4 test cases (<1%) had stderr output
Comment on attachment 40993 [details]
first try
Will land manually.
Landed as http://trac.webkit.org/changeset/49515. The problem here is a flakey test. Sigh. In these cases you're welcome to land it manually, or simply set cq+ again. The commit-queue has no way to distinguish between flakey tests and real failures, so it always assumes failures are real. We need to get rid of all our flakey tests :( Filed bug 30391. |