Bug 30253

Summary: Alter profile link format to enable multiple profile types
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pfeldman, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 30299    
Bug Blocks:    
Attachments:
Description Flags
patch
timothy: review+
[IMAGE] Screenshot with regression none

Description Alexander Pavlov (apavlov) 2009-10-09 07:02:21 PDT 
Currently, there is a single profile type (CPU profile) and its link URL format handled by WebInspector.documentClicked is as follows:

webkit-profile://<title>/<uid>

This does not warrant a possibility to introduce other types of profiles (say, Heap profiles).
The suggested profile link URL format that enables multiple profile types looks like this:

webkit-profile://<profileType>/<title>#<uid>
where <profileType>, <title>, and <uid> are URL-encoded.
Comment 1 Alexander Pavlov (apavlov) 2009-10-09 08:44:07 PDT 
Created attachment 40949 [details]
patch
Comment 2 Pavel Feldman 2009-10-12 01:53:05 PDT 
Not landing since this introduces a regression: CPU profiles with similar names are no longer grouped properly (see screenshot).
Comment 3 Pavel Feldman 2009-10-12 01:54:01 PDT 
Created attachment 41025 [details]
[IMAGE] Screenshot with regression
Comment 4 Alexander Pavlov (apavlov) 2009-10-12 02:40:02 PDT 
(In reply to comment #2)
> Not landing since this introduces a regression: CPU profiles with similar names
> are no longer grouped properly (see screenshot).

This is an unrelated regression. Filed as https://bugs.webkit.org/show_bug.cgi?id=30299
Comment 5 Pavel Feldman 2009-10-13 01:26:44 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/front-end/inspector.js
Committed r49495