Bug 30207

Summary: Qt plugins : Don't sync in paint for opaque mode
Product: WebKit Reporter: Girish Ramakrishnan <girish>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 20081    
Bug Blocks:    
Attachments:
Description Flags
Move XSync after XCreatePixmap none

Girish Ramakrishnan
Reported 2009-10-08 05:47:12 PDT
Moves XSync to the right place.
Attachments
Move XSync after XCreatePixmap (2.81 KB, patch)
2009-10-08 05:50 PDT, Girish Ramakrishnan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Girish Ramakrishnan
Comment 1 2009-10-08 05:50:13 PDT
Created attachment 40866 [details] Move XSync after XCreatePixmap
Simon Hausmann
Comment 2 2009-10-08 06:14:11 PDT
Comment on attachment 40866 [details] Move XSync after XCreatePixmap r=me
Simon Hausmann
Comment 3 2009-10-08 06:15:16 PDT
One thing that would be good to double-check: We should only re-create the drawable if we are actually changing the _size_ of the plugin/widget. If we only change the position (i.e. we are scrolling) we should not re-create the pixmap and also avoid the expensive syncX() call.
WebKit Commit Bot
Comment 4 2009-10-08 06:26:01 PDT
Comment on attachment 40866 [details] Move XSync after XCreatePixmap Clearing flags on attachment: 40866 Committed r49296: <http://trac.webkit.org/changeset/49296>
WebKit Commit Bot
Comment 5 2009-10-08 06:26:04 PDT
All reviewed patches have been landed. Closing bug.
Girish Ramakrishnan
Comment 6 2009-10-08 06:48:10 PDT
Simon, good catch! That check got lost in the QPixmap -> X Pixmap patch. I will create a patch for this one.
Note You need to log in before you can comment on or make changes to this bug.