| Summary: | Move PolicyChecker to it's own file | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||
| Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | ||||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 29947 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Adam Barth
2009-10-07 20:49:22 PDT
Created attachment 40838 [details]
Patch v1
Created attachment 40840 [details]
Patch v1
Created attachment 40842 [details]
Patch v1
Comment on attachment 40842 [details]
Patch v1
Should it really be "PolicyCallback"? and not "NavigationPolicyCallback" or "LoadPolicyCallback" or "LoaderPolicyCalback"?
Our indent-in-headers policy is under discussion on webkit-dev, but this change complies to the current style guidelines, so is fine as-is.
cq- given the question about the naming, but otherwise looks fine. You could reply with some naming justification and set cq+ yourself if you like.
(In reply to comment #4) > Should it really be "PolicyCallback"? and not "NavigationPolicyCallback" or > "LoadPolicyCallback" or "LoaderPolicyCalback"? NavigationPolicyCallback isn't right because Navigation is just one of the three things it does. LoadPolicyCallback or LoaderPolicyCalback would be fine. We can change the name later if we like. I just wanted to make it different from PolicyChecker in the short term. Comment on attachment 40842 [details]
Patch v1
I need to land this manually.
Committed r49290: <http://trac.webkit.org/changeset/49290> |