Bug 301359
| Summary: | Remove unused WebLocalFrameLoaderClient::m_useIconLoadingClient and related code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Page Loading | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | beidson, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=174700 | ||
| Bug Depends on: | |||
| Bug Blocks: | 301086, 301088 | ||
Adrian Perez
The WebLocalFrameLoaderClient::m_useIconLoadingClient member is set but never checked elsewhere, since 191542@main. The current assumption is that an IconLoadingClient is always attached to a Page -- either the default, empty implementation, or a port-specific one (as done by GTK and Cocoa).
Let's clean this up!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/52895
EWS
Committed 302050@main (bab06beb1364): <https://commits.webkit.org/302050@main>
Reviewed commits have been landed. Closing PR #52895 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/163285876>