Bug 30111

Summary:

Move FrameLoader::canLoad to SecurityOrigin

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

29947

Attachments:

Description	Flags
Patch v1	none

Description Adam Barth 2009-10-05 23:57:43 PDT

Move FrameLoader::canLoad to SecurityOrigin

Comment 1 Adam Barth 2009-10-05 23:59:03 PDT

Created attachment 40697 [details]
Patch v1

Comment 2 Eric Seidel (no email) 2009-10-06 09:55:48 PDT

Comment on attachment 40697 [details]
Patch v1

This is a little trickier than I expected since you're changing the signature of the function as you move it, but looks OK.

Also, I wonder if we shouldn't rename this "mayLoad" to satisfy my 3rd grade english teacher. :)

Comment 3 Adam Barth 2009-10-06 10:29:06 PDT

There's a bunch of other canFoo methods on security origin already.  I support renaming them, but we should do them all at the same time.

Comment 4 WebKit Commit Bot 2009-10-06 18:14:31 PDT

Comment on attachment 40697 [details]
Patch v1

Clearing flags on attachment: 40697

Committed r49212: <http://trac.webkit.org/changeset/49212>

Comment 5 WebKit Commit Bot 2009-10-06 18:14:34 PDT

All reviewed patches have been landed.  Closing bug.