Bug 30109

Summary: Move m_openedByDOM to Page
Product: WebKit Reporter: Adam Barth <abarth>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 29947    
Attachments:
Description Flags
Patch v1
abarth: commit-queue-
patch with typos fixed. none

Adam Barth
Reported 2009-10-05 22:14:39 PDT
We only need one instance of m_openedByDOM per page, we should move it to a page-scoped object. Notice that it's only ever touched for the main frame.
Attachments
Patch v1 (5.35 KB, patch)
2009-10-05 22:15 PDT, Adam Barth 		abarth: commit-queue-
DetailsFormatted DiffDiff
patch with typos fixed. (6.45 KB, patch)
2009-10-05 23:05 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-10-05 22:15:48 PDT
Created attachment 40688 [details] Patch v1
Adam Barth
Comment 2 2009-10-05 22:53:13 PDT
Comment on attachment 40688 [details] Patch v1 There are two typos I need to fix before landing.
Adam Barth
Comment 3 2009-10-05 23:05:32 PDT
Created attachment 40693 [details] patch with typos fixed.
Eric Seidel (no email)
Comment 4 2009-10-06 09:50:39 PDT
Comment on attachment 40693 [details] patch with typos fixed. LGTM.
WebKit Commit Bot
Comment 5 2009-10-06 11:20:41 PDT
Comment on attachment 40693 [details] patch with typos fixed. Clearing flags on attachment: 40693 Committed r49196: <http://trac.webkit.org/changeset/49196>
WebKit Commit Bot
Comment 6 2009-10-06 11:20:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.