Summary: | Incorrect forward declaration of 'struct FrameLoadRequest' as 'class FrameLoadRequest' leads to compile warnings | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, commit-queue, darin, eric, jparent | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
James Robinson
2009-10-05 13:51:00 PDT
Created attachment 40658 [details]
Patch to fix decl
Comment on attachment 40658 [details] Patch to fix decl Rejecting patch 40658 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Created attachment 40661 [details]
Patch including ChangeLog entry
Comment on attachment 40661 [details] Patch including ChangeLog entry LGTM. I'm assuming you meant cq? as well. (Sadly bugzilla-tool post-diff has no --commit-queue option yet. bug 29202.) The struct one should go down in the next paragraph with the other struct rather than in the class paragraph. Comment on attachment 40661 [details]
Patch including ChangeLog entry
Rejecting patch 40661 from commit-queue.
Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11378 test cases.
fast/dom/prototype-inheritance.html -> failed
Exiting early after 1 failures. 5487 tests run.
95.67s total testing time
5486 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output
Created attachment 40663 [details]
Moves the decl down with the other 'struct ...' declaration
Sorry, the bots were behind. They were showing green but the build was actually red. Hence the invalid rejection. I'll file a bug about the commit-queue not noticing that hte bots were behind. Comment on attachment 40663 [details] Moves the decl down with the other 'struct ...' declaration Rejecting patch 40663 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/loader/RedirectScheduler.h A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/libexec/git-core//git-svn line 469 Need to remove the "No new tests (OOPS)" line from the change log. Created attachment 40670 [details]
Removes "No new tests (OOPS) line from ChangeLog"
Comment on attachment 40670 [details]
Removes "No new tests (OOPS) line from ChangeLog"
Rejecting patch 40670 from commit-queue.
Failed to run "WebKitTools/Scripts/build-webkit" exit_code: 1
Last 500 characters of output:
rivedSources/WebCore/JSCanvasRenderingContext3D.cpp -o /Users/eseidel/Projects/build/WebCore.build/Release/WebCore.build/Objects-normal/i386/JSCanvasRenderingContext3D.o
** BUILD FAILED **
The following build commands failed:
WebCore:
Distributed-CompileC /Users/eseidel/Projects/build/WebCore.build/Release/WebCore.build/Objects-normal/i386/RenderThemeMac.o /Users/eseidel/Projects/CommitQueue/WebCore/rendering/RenderThemeMac.mm normal i386 objective-c++ com.apple.compilers.gcc.4_2
(1 failure)
Comment on attachment 40670 [details] Removes "No new tests (OOPS) line from ChangeLog" The commit-queue has landed nearly 400 patches by now, and this is the first time I've seen false failures like these. So either this is a real failure caused by this patch, or you've hit bug 30098 twice (I saw bug 30098 for the first time today!). Not sure yet. Either way, my apologies for the inconvenience. Comment on attachment 40670 [details] Removes "No new tests (OOPS) line from ChangeLog" Clearing flags on attachment: 40670 Committed r49144: <http://trac.webkit.org/changeset/49144> All reviewed patches have been landed. Closing bug. Thanks! I was just abou to fix this. ;) |