Bug 30020

Summary: [chromium] Fix WebGL build after CustomGetter constructor changes
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dglazkov, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2009-10-02 09:32:55 PDT
https://bugs.webkit.org/show_bug.cgi?id=29940 changed the form of V8 bindings for constructors marked CustomGetter. The constructors being proposed in the WebGL spec for new array-like objects don't need this special treatment so the CustomGetter should be changed to JSCCustomGetter. I'm not 100% sure even this attribute is needed but I've built both WebKit and Chromium with this change and verified that it fixes the Chromium WebGL build without affecting the WebKit build.
Attachments
Patch (3.21 KB, patch)
2009-10-02 09:37 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2009-10-02 09:37:31 PDT
Created attachment 40530 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2009-10-02 11:55:16 PDT
Can we just make these non-custom? Doesn't look like they're doing much.
Kenneth Russell
Comment 3 2009-10-02 14:16:51 PDT
I tried removing the JSCCustomGetter attribute and doing so breaks the WebKit build. It seems this patch is correct for both Chrome and WebKit.
Dimitri Glazkov (Google)
Comment 4 2009-10-02 15:06:57 PDT
Comment on attachment 40530 [details] Patch ok.
WebKit Commit Bot
Comment 5 2009-10-02 15:33:48 PDT
Comment on attachment 40530 [details] Patch Clearing flags on attachment: 40530 Committed r49049: <http://trac.webkit.org/changeset/49049>
WebKit Commit Bot
Comment 6 2009-10-02 15:33:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.