Bug 30007

Summary: [GStreamer] data: source could also support non-base64 encoded URIs
Product: WebKit Reporter: Sebastian Dröge (slomo) <slomo>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alex, eric.carlson, eric, gustavo, pnormand, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch gustavo: review+

Sebastian Dröge (slomo)
Reported 2009-10-02 01:57:36 PDT
Hi, the media player should support non-base64 URIs too. Example use case for this would be plaintext playlists, subtitles, ... Should be quite easy to add support for that but make sure to convert from text/plain,charset=XYZ to UTF8 before passing to GStreamer.
Attachments
proposed patch (15.39 KB, patch)
2010-12-10 02:01 PST, Philippe Normand 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sebastian Dröge (slomo)
Comment 1 2010-01-30 01:24:28 PST
This can be fixed by updating the data URI source from gst-plugins-bad GIT btw. http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/dataurisrc
Philippe Normand
Comment 2 2010-02-15 03:51:59 PST
(In reply to comment #1) > This can be fixed by updating the data URI source from gst-plugins-bad GIT btw. > > http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/dataurisrc I can attach a patch but the style will complain big time! 334 errors in the new DataSourceGStreamer.cpp .. what should we do? Updating anyway or just wait next -bad release and bump requirements ?
Philippe Normand
Comment 3 2010-02-15 03:52:31 PST
Gustavo, ^^ ;)
Gustavo Noronha (kov)
Comment 4 2010-02-15 09:04:07 PST
(In reply to comment #2) > (In reply to comment #1) > > This can be fixed by updating the data URI source from gst-plugins-bad GIT btw. > > > > http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/dataurisrc > > I can attach a patch but the style will complain big time! 334 errors in the > new DataSourceGStreamer.cpp .. what should we do? Updating anyway or just wait > next -bad release and bump requirements ? Wait for release, and bump requirements sounds like a good idea to me.
Philippe Normand
Comment 5 2010-02-15 09:14:10 PST
(In reply to comment #4) > (In reply to comment #2) > > (In reply to comment #1) > > > This can be fixed by updating the data URI source from gst-plugins-bad GIT btw. > > > > > > http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/dataurisrc > > > > I can attach a patch but the style will complain big time! 334 errors in the > > new DataSourceGStreamer.cpp .. what should we do? Updating anyway or just wait > > next -bad release and bump requirements ? > > Wait for release, and bump requirements sounds like a good idea to me. According to http://gstreamer.freedesktop.org/wiki/ReleasePlanning2010 -bad 0.10.18 should be released next week
Philippe Normand
Comment 6 2010-12-10 02:01:18 PST
Created attachment 76176 [details] proposed patch
Gustavo Noronha (kov)
Comment 7 2010-12-10 02:05:29 PST
Comment on attachment 76176 [details] proposed patch ok!
Philippe Normand
Comment 8 2010-12-10 02:26:37 PST
Committed r73700: <http://trac.webkit.org/changeset/73700>
Philippe Normand
Comment 9 2010-12-10 02:27:25 PST
*** Bug 37564 has been marked as a duplicate of this bug. ***
WebKit Review Bot
Comment 10 2010-12-10 11:45:08 PST
http://trac.webkit.org/changeset/73700 might have broken GTK Linux 32-bit Debug
Note You need to log in before you can comment on or make changes to this bug.