Bug 29948

Summary:

Factor RedirectScheduler out of FrameLoader

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mjs, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

29947

Attachments:

Description	Flags
Patch v1	mjs: review+

Description Adam Barth 2009-09-30 19:29:36 PDT

The code for dealing with redirect scheduling is a separable concern from the main "loading a frame" task of the FrameLoader.  I'm going to take this in baby steps to help make the changes reviewable.  Patch forthcoming.

Comment 1 Adam Barth 2009-09-30 19:34:49 PDT

Created attachment 40417 [details]
Patch v1

Comment 2 Adam Barth 2009-09-30 19:40:13 PDT

I should also say that I'll remove the FrameLoader::schedule* methods in a future patch.  I didn't want to touch all the clients in this patch.

Comment 3 Sam Weinig 2009-09-30 20:00:20 PDT

Can RedirectScheduler go in its own file?

Comment 4 Adam Barth 2009-09-30 20:03:12 PDT

(In reply to comment #3)
> Can RedirectScheduler go in its own file?

Absolutely.  I just wanted to make the diff easier to read.

Comment 5 Adam Barth 2009-09-30 20:19:14 PDT

Future patch in https://bugs.webkit.org/show_bug.cgi?id=29950

Comment 6 Maciej Stachowiak 2009-09-30 21:07:43 PDT

Comment on attachment 40417 [details]
Patch v1

I suggest removing this comment, we don't need to worry about the next line being removed accidentally since it would break the build:

// We need an explicit dtor because ScheduledRedirection is an incomplete type here.

r=me

Comment 7 Adam Barth 2009-09-30 21:25:51 PDT

Committed r48958: <http://trac.webkit.org/changeset/48958>