Bug 29948

Summary: Factor RedirectScheduler out of FrameLoader
Product: WebKit Reporter: Adam Barth <abarth>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mjs, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 29947    
Attachments:
Description Flags
Patch v1 mjs: review+

Adam Barth
Reported 2009-09-30 19:29:36 PDT
The code for dealing with redirect scheduling is a separable concern from the main "loading a frame" task of the FrameLoader. I'm going to take this in baby steps to help make the changes reviewable. Patch forthcoming.
Attachments
Patch v1 (28.52 KB, patch)
2009-09-30 19:34 PDT, Adam Barth 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-09-30 19:34:49 PDT
Created attachment 40417 [details] Patch v1
Adam Barth
Comment 2 2009-09-30 19:40:13 PDT
I should also say that I'll remove the FrameLoader::schedule* methods in a future patch. I didn't want to touch all the clients in this patch.
Sam Weinig
Comment 3 2009-09-30 20:00:20 PDT
Can RedirectScheduler go in its own file?
Adam Barth
Comment 4 2009-09-30 20:03:12 PDT
(In reply to comment #3) > Can RedirectScheduler go in its own file? Absolutely. I just wanted to make the diff easier to read.
Adam Barth
Comment 5 2009-09-30 20:19:14 PDT
Future patch in https://bugs.webkit.org/show_bug.cgi?id=29950
Maciej Stachowiak
Comment 6 2009-09-30 21:07:43 PDT
Comment on attachment 40417 [details] Patch v1 I suggest removing this comment, we don't need to worry about the next line being removed accidentally since it would break the build: // We need an explicit dtor because ScheduledRedirection is an incomplete type here. r=me
Adam Barth
Comment 7 2009-09-30 21:25:51 PDT
Committed r48958: <http://trac.webkit.org/changeset/48958>
Note You need to log in before you can comment on or make changes to this bug.