Summary: | [Qt] gotoAnchor in QtWebKit | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tor Arne Vestbø <vestbo> | ||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | CC: | ariya.hidayat, tonikitoo | ||||
Priority: | P2 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 31552 | ||||||
Attachments: |
|
Description
Tor Arne Vestbø
2009-09-29 05:34:18 PDT
*** Bug 29885 has been marked as a duplicate of this bug. *** Created attachment 48791 [details]
Patch
Comment on attachment 48791 [details] Patch Nice! > +void QWebFrame::scrollToAnchor(const QString &anchor) [...] > + void scrollToAnchor(const QString &anchor); Would be good to fix the & position before landing :) > > +void QWebFrame::scrollToAnchor(const QString &anchor)
> [...]
> > + void scrollToAnchor(const QString &anchor);
>
> Would be good to fix the & position before landing :)
The whole file is still using Qt code style for this. Should I switch to WebKit's for this particular function only?
Manually committed in r54857: http://trac.webkit.org/changeset/54857 |