Bug 298004
| Summary: | Add a Test-Sequence header to the webkitpy <-> WKTR/DRT server protocol | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ben_schwartz, jbedard, Morningstar, rreapor, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Sneddon [:gsnedders]
We've had a variety of off-by-one errors across the protocol over the years. e.g., bug 235733, bug 273212, bug 274330.
We should make these a lot harder to accidentally slip through, not least because they can cause bogus results for the rest of the test run.
Adding a Test-Sequence header, where WKTR and DRT and webkitpy can all keep count of the number of run test commands sent, allows some basic synchronisation.
It's less ideal than setting some abstract UUID (because incrementing accidentally is a lot easier), but it's possible to land this in a low-risk, low-impact way that doesn't break the communication protocol and you can still use current webkitpy with older WKTR/DRT, which is nice for people trying to bisect things based on build archives.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/159323672>
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/49978