Bug 29617

Summary: WebKit Chromium Port: Upstreaming gyp files into webkit
Product: WebKit Reporter: Yaar Schnitman <yaar>
Component: WebKit Misc.Assignee: Yaar Schnitman <yaar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 28396    
Attachments:
Description Flags
Adds JavaScriptCore.gyp, WebCore.gyp and chromium/features.gypi
levin: review-
copyright & FIXME resolved none

Yaar Schnitman
Reported 2009-09-21 14:51:08 PDT
This patch is part of the webkit chromium port project as described here: http://trac.webkit.org/wiki/Chromium The webcore & javascriptcore building steps of chromium have been decoupled from chromium gyp-based build system, and can now be moved to the webkit tree: 1. A chromium port directory was created: WebKit/chromium 2. features.gypi, which controls which features are turned on/off in webkit, has been imported: WebKit/chromium/features.gypi 3. WebCore.gyp and JavaScriptCore.gyp have been ported and live inside the new directories WebCore/WebCore.gyp/ and JavaScriptCore/JavaScriptCore.gyp/. (We use dedicated directories so that the gyp outputs don't overwrite the existing generic xcodeproj, vsproj, files. Once this patch is commited, downstream chromium gyp files should be updated to point at new upstream gyps.
Attachments
Adds JavaScriptCore.gyp, WebCore.gyp and chromium/features.gypi (40.48 KB, patch)
2009-09-21 15:11 PDT, Yaar Schnitman 		levin: review-
DetailsFormatted DiffDiff
copyright & FIXME resolved (44.45 KB, patch)
2009-09-21 16:37 PDT, Yaar Schnitman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yaar Schnitman
Comment 1 2009-09-21 15:11:42 PDT
Created attachment 39885 [details] Adds JavaScriptCore.gyp, WebCore.gyp and chromium/features.gypi
David Levin
Comment 2 2009-09-21 15:19:09 PDT
Comment on attachment 39885 [details] Adds JavaScriptCore.gyp, WebCore.gyp and chromium/features.gypi Quick comments from a brief look: The copyrights are not a correct format for WebKit. "TODO(*):" should be "FIXME:"
Yaar Schnitman
Comment 3 2009-09-21 16:37:00 PDT
Created attachment 39893 [details] copyright & FIXME resolved Thanks for reviewing this.
WebKit Commit Bot
Comment 4 2009-09-22 10:34:51 PDT
Comment on attachment 39893 [details] copyright & FIXME resolved Clearing flags on attachment: 39893 Committed r48640: <http://trac.webkit.org/changeset/48640>
WebKit Commit Bot
Comment 5 2009-09-22 10:34:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.