Summary: | Update WebGL-related copyrights | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||
Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED LATER | ||||||
Severity: | Minor | CC: | cmarrin, dglazkov, fishd, oliver, vangelis | ||||
Priority: | P3 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Kenneth Russell
2009-09-17 13:12:53 PDT
(In reply to comment #0) > Google contributed a significant amount of the code integrated by Apple in > https://bugs.webkit.org/show_bug.cgi?id=29010 , but I neglected to update the > copyright headers in the affected files. On the recommendation of Apple here is > a minor patch updating the relevant files' copyrights. Please list the "significant" code -- my understanding is that it was just the original implementations of Canvas*Array. The contributions were: - The original implementations of the Canvas*Array classes and their IDL - Updates to many of the CanvasRenderingContext3D entry points to bring them up to date with the then-current WebGL specification - Additions of the CanvasArray constructors to the DOMWindow IDL These are the only files touched by the attached copyright notice patch. (In reply to comment #2) > The contributions were: > - The original implementations of the Canvas*Array classes and their IDL > - Updates to many of the CanvasRenderingContext3D entry points to bring them > up to date with the then-current WebGL specification > - Additions of the CanvasArray constructors to the DOMWindow IDL > > These are the only files touched by the attached copyright notice patch. I think the confusion here is that there is no patch attached :D Created attachment 39736 [details]
Patch updating copyrights to affected files.
Sorry about that; attached.
Comment on attachment 39736 [details]
Patch updating copyrights to affected files.
I don't know what source files were modified, vs. started from fresh -- no point in me being the requested reviewer.
Comment on attachment 39736 [details]
Patch updating copyrights to affected files.
No ChangeLog. r-
Why are we bothering to update this? Lets just fix the copyrights next time we touch those files... no?
Closing per eric's comments -- he's right, we normally just correct copyright notices when we modify files and realise that the copyright info is out of date. |