Bug 29111

Summary: [V8] Cleanup includes and forward declarations in V8Proxy.h
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
test none

Nate Chapin
Reported 2009-09-09 16:45:51 PDT
https://bugs.webkit.org/show_bug.cgi?id=29051 demonstrated that V8Proxy.h could use some cleanup work. I did the bare minimum to get this file suitable for upstreaming, and it appears I should have double-checked the includes and forward declarations to see what was no longer necessary.
Attachments
patch (2.57 KB, patch)
2009-09-09 16:50 PDT, Nate Chapin 		no flags
DetailsFormatted DiffDiff
test (76.73 KB, text/plain)
2009-09-09 22:54 PDT, Cho Kyung Bin 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2009-09-09 16:50:51 PDT
Created attachment 39311 [details] patch
Adam Barth
Comment 2 2009-09-09 17:02:26 PDT
Comment on attachment 39311 [details] patch Awesome patch!
WebKit Commit Bot
Comment 3 2009-09-09 17:39:25 PDT
Comment on attachment 39311 [details] patch Clearing flags on attachment: 39311 Committed r48238: <http://trac.webkit.org/changeset/48238>
WebKit Commit Bot
Comment 4 2009-09-09 17:39:28 PDT
All reviewed patches have been landed. Closing bug.
Cho Kyung Bin
Comment 5 2009-09-09 22:54:16 PDT
Created attachment 39323 [details] test test
David Levin
Comment 6 2009-09-09 23:05:27 PDT
Comment on attachment 39323 [details] test According to biny77 this was done by mistake.
Note You need to log in before you can comment on or make changes to this bug.