Bug 28887

Summary: Expose functions to change the focus ring color for Linux Chromium
Product: WebKit Reporter: Evan Stade <estade>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: agl, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch
levin: review+, levin: commit-queue-
ditched variable name none

Evan Stade
Reported 2009-09-01 13:12:57 PDT
we will use this to make the focus ring match the system theme.
Attachments
patch (2.61 KB, patch)
2009-09-01 13:15 PDT, Evan Stade 		levin: review+
levin: commit-queue-
DetailsFormatted DiffDiff
ditched variable name (2.60 KB, patch)
2009-09-02 11:32 PDT, Evan Stade 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Evan Stade
Comment 1 2009-09-01 13:15:23 PDT
Created attachment 38882 [details] patch
Evan Stade
Comment 2 2009-09-01 13:15:55 PDT
chromium side is http://codereview.chromium.org/173642
Adam Langley
Comment 3 2009-09-01 15:53:00 PDT
I am not a WebKit reviewer. You'll have to send it to someone who is, but LGTM.
David Levin
Comment 4 2009-09-01 22:16:45 PDT
Comment on attachment 38882 [details] patch > Index: WebCore/rendering/RenderThemeChromiumLinux.h > + void setFocusRingColor(const Color& color); Parameter names shouldn't be included if they don't add information, so remove "color" on landing this.
Evan Stade
Comment 5 2009-09-02 10:36:59 PDT
thanks for the review. I am not a committer.
Adam Langley
Comment 6 2009-09-02 10:38:05 PDT
estate: if you update the patch, I can mark it for commit queue.
Evan Stade
Comment 7 2009-09-02 11:32:29 PDT
Created attachment 38934 [details] ditched variable name updated
Eric Seidel (no email)
Comment 8 2009-09-02 13:04:51 PDT
Comment on attachment 38934 [details] ditched variable name Turns out the commit-queue spins if patches are marked cq+ w/o being reviewd. :( bug 28916. I'll fix it. But for now, markign this r+ too. :)
Eric Seidel (no email)
Comment 9 2009-09-02 13:05:40 PDT
Comment on attachment 38934 [details] ditched variable name Rejecting patch 38934 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/build-webkit failed with exit code 1
Evan Stade
Comment 10 2009-09-02 13:10:26 PDT
does the above message mean that it failed to compile?
Eric Seidel (no email)
Comment 11 2009-09-02 13:20:48 PDT
Comment on attachment 38934 [details] ditched variable name build-webkit was broken for a moment. Not sure why the bots weren't showing it.
Eric Seidel (no email)
Comment 12 2009-09-02 13:31:33 PDT
Comment on attachment 38934 [details] ditched variable name Rejecting patch 38934 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None
Eric Seidel (no email)
Comment 13 2009-09-02 13:34:18 PDT
Comment on attachment 38934 [details] ditched variable name The commit-queue hates us tonight. Race condition during commit. bug 28316.
Eric Seidel (no email)
Comment 14 2009-09-02 13:45:56 PDT
Comment on attachment 38934 [details] ditched variable name Clearing flags on attachment: 38934 Committed r47992: <http://trac.webkit.org/changeset/47992>
Eric Seidel (no email)
Comment 15 2009-09-02 13:46:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.