Summary: | Expose functions to change the focus ring color for Linux Chromium | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Evan Stade <estade> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | agl, eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Evan Stade
2009-09-01 13:12:57 PDT
Created attachment 38882 [details]
patch
chromium side is http://codereview.chromium.org/173642 I am not a WebKit reviewer. You'll have to send it to someone who is, but LGTM. Comment on attachment 38882 [details] patch > Index: WebCore/rendering/RenderThemeChromiumLinux.h > + void setFocusRingColor(const Color& color); Parameter names shouldn't be included if they don't add information, so remove "color" on landing this. thanks for the review. I am not a committer. estate: if you update the patch, I can mark it for commit queue. Created attachment 38934 [details]
ditched variable name
updated
Comment on attachment 38934 [details] ditched variable name Turns out the commit-queue spins if patches are marked cq+ w/o being reviewd. :( bug 28916. I'll fix it. But for now, markign this r+ too. :) Comment on attachment 38934 [details]
ditched variable name
Rejecting patch 38934 from commit-queue. This patch will require manual commit.
WebKitTools/Scripts/build-webkit failed with exit code 1
does the above message mean that it failed to compile? Comment on attachment 38934 [details]
ditched variable name
build-webkit was broken for a moment. Not sure why the bots weren't showing it.
Comment on attachment 38934 [details]
ditched variable name
Rejecting patch 38934 from commit-queue. This patch will require manual commit.
Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None
Comment on attachment 38934 [details] ditched variable name The commit-queue hates us tonight. Race condition during commit. bug 28316. Comment on attachment 38934 [details] ditched variable name Clearing flags on attachment: 38934 Committed r47992: <http://trac.webkit.org/changeset/47992> All reviewed patches have been landed. Closing bug. |