Bug 283172 – [Media] Avoid play() call during seek flow before the finishSeek() call

• Component: Media
• Status: RESOLVED INVALID

[Enrique Ocaña]

During the video playback states should ideally flow as play -> pause -> seek_start -> seek_done -> play, but randomly it is observed that the play event is being sent before finishing the seek (seek_done) i.e, play -> pause -> seek_start -> play -> seek_done. Ideally play call might be triggered continuously by the webapp when we are playing a video, so in our scenario between seek_start and seek_done we should avoid the play call.

See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1423

[Enrique Ocaña]

Pull request: https://github.com/WebKit/WebKit/pull/36695

[Radar WebKit Bug Importer]

<rdar://problem/140414465>

[EWS]

Committed 287274@main (71a7e0a09291): <https://commits.webkit.org/287274@main>

Reviewed commits have been landed. Closing PR #36695 and removing active labels.

[Jean-Yves Avenard [:jya]]

This change is wrong.

as written in https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1423

 It breaks the spec. There's nothing in the spec that makes the play event being conditional of a seek having been completed.

https://html.spec.whatwg.org/multipage/media.html#internal-play-steps

if you call play() (even during a seek) and playback is allowed, the play event should be fired.

Found be investigating why Duolingo was now broken in Safari STP 210.

[Jean-Yves Avenard [:jya]]

Reopened Bugzilla.
Broke duolingo, calling play() during a seek() is allowed by the spec. And the play event should be fired even if the seek hasn't completed., tracking revert in https://bugs.webkit.org/show_bug.cgi?id=285568.

[Enrique Ocaña]

After analyzing the spec and discussing it with the original https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1423 reporter, we've concluded that the revert is fine and this bug should be resolved as invalid, since it's against the spec. Thanks for having taken the effort to prove your point, Jean-Yves.